UFM: Code tidy-up #19687
Merged
UFM: Code tidy-up #19687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Tidies up UFM component code by inlining element names, removing unused imports/guards, and improving filter handling.
- Inlined
@customElementname constants and removedelementNamevariables. - Dropped the unused
nothingimport and early return, replacing it with optional chaining. - Added a console warning for missing filters in
ufm-element-base.ts.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ufm-render.element.ts | Inlined element name, reformatted comment. |
| ufm-element-base.ts | Removed nothing import/early return, relocated #ufmContext, added optional chaining and warnings. |
| localize.element.ts | Inlined element name, removed constant, added eslint-disable. |
| link.element.ts | Inlined element name, removed constant, added eslint-disable. |
| label-value.element.ts | Inlined element name, removed constant, added eslint-disable. |
| content-name.element.ts | Inlined element name, removed constant, added eslint-disable. |
src/Umbraco.Web.UI.Client/src/packages/ufm/components/ufm-render/ufm-render.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/ufm/components/ufm-element-base.ts
Show resolved
Hide resolved
iOvergaard
approved these changes
Jul 8, 2025
Co-authored-by: Copilot <[email protected]>
iOvergaard
requested changes
Jul 8, 2025
src/Umbraco.Web.UI.Client/src/packages/ufm/components/content-name/content-name.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/ufm/components/ufm-element-base.ts
Show resolved
Hide resolved
iOvergaard
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whilst working on #19684 and #19685, I tidied up some UFM code, all non-breaking.