Fix issue with newly created template under an existing one #19669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
requested changes
Aug 12, 2025
Member
nielslyngsoe
left a comment
nielslyngsoe
left a comment
There was a problem hiding this comment.
Declining this for now, seems like another solution should be found. :-)
...raco.Web.UI.Client/src/packages/templating/templates/workspace/template-workspace.context.ts
Outdated
Show resolved
Hide resolved
nielslyngsoe
added
the
state/sprint-candidate
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where newly created templates under an existing template would lose their master template relationship and appear to have unsaved changes. The fix ensures that when creating a template with a parent, the master template relationship is properly established and maintained.
Key changes:
- Modified template creation to properly pass master template information during scaffolding
- Updated type annotations for better type safety
- Fixed the logic for setting master template relationships in newly created templates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| template-workspace.context.ts | Updates template creation logic to properly handle master template relationships and improves type safety |
| template-detail.server.data-source.ts | Ensures master template preset is properly applied during template scaffolding |
...raco.Web.UI.Client/src/packages/templating/templates/workspace/template-workspace.context.ts
Outdated
Show resolved
Hide resolved
…an existing editor
also refactor function a bit
nielslyngsoe
reviewed
Sep 3, 2025
Member
nielslyngsoe
left a comment
nielslyngsoe
left a comment
There was a problem hiding this comment.
Super duper, its work as expected now!
Did notice the Discard Changes dialog, but we agreed this is another case. so that will be handled elsewhere.
nielslyngsoe
approved these changes
Sep 3, 2025
nielslyngsoe
deleted the
v16/bugfix/fix-post-create-template-with-master-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves: #19632
Description
The linked issue illustrates problems when creating a template under an existing one - the newly created template loses it's updates and appears to have changes when it doesn't.
The problem looks to occur when we attempt to load the newly created template and we don't get the data returned from the API, rather the originally scaffolded content.
This Pull Request makes it possible to:
Testing
Create a template under an existing one, and verify the master template is correctly identified for subsequent editing.
This item has been added to our backlog AB#55723