Variant workspace breadcrumb item parentheses #19599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parentheses will be added to unnamed variant ancestor items.
(for semantics)
Saves on the string allocation.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the breadcrumb item naming and URL logic for variant workspaces so that only invariant ancestors are wrapped in parentheses.
- Updated import organization and type separation for better clarity.
- Refactored the logic for determining the variant name and breadcrumb URL construction.
- Added the "last-item" attribute to the final breadcrumb item for improved UI indication.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-breadcrumb/workspace-variant-menu-breadcrumb/workspace-variant-menu-breadcrumb.element.ts | Refactored variant name resolution and URL generation for variant breadcrumbs. |
| src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-breadcrumb/workspace-menu-breadcrumb/workspace-menu-breadcrumb.element.ts | Simplified URL generation for menu breadcrumbs and added final item designation. |
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-breadcrumb/workspace-variant-menu-breadcrumb/workspace-variant-menu-breadcrumb.element.ts:100
- [nitpick] The parameter name 'variantId' might be misleading since it represents a variant object; consider renaming it to 'variant' for improved clarity.
const variant = structureItem.variants.find((variantId) => this._workspaceActiveVariantId?.compare(variantId));
src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-breadcrumb/workspace-variant-menu-breadcrumb/workspace-variant-menu-breadcrumb.element.ts:113
- [nitpick] The fallback label '(#general_unknown)' differs from the previous fallback 'Unknown' used earlier; consider unifying the fallback text for consistency.
return structureItem.variants?.[0]?.name ?? '(#general_unknown)';
madsrasmussen
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworks the parentheses usage for the breadcrumb items on a variant (document) workspace.
It was previously if you were on a variant document, the breadcrumbs would wrap each invariant ancestor name with parentheses, including the document-root.