Skip to content

Conversation

@lauraneto
Copy link
Contributor

The log viewer date range input was changed from using input to umb-input-date, but the event handlers weren't updated accordingly.

If there's an existing issue for this PR then this fixes #19382.

The log viewer date range input was changed from using `input` to `umb-input-date`, but the event handlers weren't updated accordingly.
Copilot AI review requested due to automatic review settings May 30, 2025 10:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the log viewer date range selector to use the correct umb-input-date event handlers and refactors how date changes propagate to the workspace context.

  • Switched from global input listeners and manual showPicker() hacks to per-field @change handlers.
  • Imported UUIInputEvent and introduced dedicated #setStartDate/#setEndDate methods that call a shared #updateFiltered helper.
  • Removed unused queryAll and cleaned up event listener setup/teardown.
Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/src/packages/log-viewer/components/log-viewer-date-range-selector.element.ts:69

  • After removing the manual showPicker() click handlers, verify that the date picker still opens on click by default; otherwise users may be unable to invoke the calendar UI.
<umb-input-date @change=${this.#setStartDate}

src/Umbraco.Web.UI.Client/src/packages/log-viewer/components/log-viewer-date-range-selector.element.ts:70

  • Confirm that umb-input-date emits a change event when its value updates; if you need to capture every keystroke or immediate edits, consider using @input or the component-specific @value-change event instead of @change.
@change=${this.#setStartDate}

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests out nicely. I can see the data filters being applied and they are retained now after amending the error level filter.

@AndyButland AndyButland enabled auto-merge (squash) May 30, 2025 10:37
@AndyButland AndyButland merged commit b403518 into main May 30, 2025
28 checks passed
@AndyButland AndyButland deleted the v16/bugfix/19382-Log-Viewer-date-filtering-not-working branch May 30, 2025 10:44
AndyButland pushed a commit that referenced this pull request May 30, 2025
…lement (#19451)

Fixes #19382 by using proper umb-input-date events

The log viewer date range input was changed from using `input` to `umb-input-date`, but the event handlers weren't updated accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] V15 - Backoffice: Log Viewer date filtering not working

3 participants