V16 QA Publish Console Error Logs #19417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for capturing frontend console errors during E2E runs by initializing a console-errors.json file, wiring up a new CONSOLE_ERRORS_PATH environment variable, and publishing the log as a pipeline artifact.
- Ensure
console-errors.jsonis created/prepared in the postinstall script - Extend
.envgeneration andconfig.jsto includeCONSOLE_ERRORS_PATH - Update nightly/azure pipelines to capture and publish the console error log
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Umbraco.Tests.AcceptanceTest/postinstall.js | Initialize console-errors.json when missing |
| tests/Umbraco.Tests.AcceptanceTest/config.js | Add CONSOLE_ERRORS_PATH to generated .env and cleanup duplicates |
| tests/Umbraco.Tests.AcceptanceTest/package.json | Bump @umbraco/playwright-testhelpers dependency version |
| build/nightly-E2E-test-pipelines.yml | Export CONSOLE_ERRORS_PATH and copy the log as an artifact |
| build/azure-pipelines.yml | Export CONSOLE_ERRORS_PATH and copy the log as an artifact |
Files not reviewed (1)
- tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
tests/Umbraco.Tests.AcceptanceTest/postinstall.js:24
- Consider adding an automated test to verify that
postinstall.jscreatesconsole-errors.jsonwhen it does not exist, ensuring this new behavior doesn't regress.
fs.writeFileSync(consoleErrorsPath, consoleErrorsFileContent);
nhudinh0309
reviewed
May 27, 2025
Contributor
nhudinh0309
left a comment
nhudinh0309
left a comment
There was a problem hiding this comment.
It looks good but in the pipeline, where can I view the file which write the console log?
Contributor
Author
|
The console logs are in the same place as the trace.zips from our failed/flaky tests. In the published artefacts > Anyof the test workers > console-errors.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on logging all the Console Errors from the frontend while running our E2E test.
It allows us to see any errors we do not see in the UI while running the tests.