Fix observe property string name #19411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR corrects a reactive property name in the willUpdate lifecycle hook to ensure the component reacts to the intended change.
- Replaced
'type'with'property'in thechangedPropertiescheck. - Ensures that updates now trigger when the
propertyinput changes.
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/views/edit/content-editor-property.element.ts:36
- Add or update unit tests to cover the scenario where the
propertyinput changes, ensuring that the reactive update path inwillUpdateis exercised.
if (changedProperties.has('property') || changedProperties.has('variantId') || changedProperties.has('_context')) {
Comment on lines
34
to
+36
| override willUpdate(changedProperties: Map<string, any>) { | ||
| super.willUpdate(changedProperties); | ||
| if (changedProperties.has('type') || changedProperties.has('variantId') || changedProperties.has('_context')) { | ||
| if (changedProperties.has('property') || changedProperties.has('variantId') || changedProperties.has('_context')) { |
There was a problem hiding this comment.
[nitpick] Consider extracting the observed property keys ('property', 'variantId', '_context') into a constant or array to avoid repeating magic strings and simplify future maintenance.
iOvergaard
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a naming mistake here, which does not affect anything currently, but should be corrected — cause I think that is just a coincidence.
(This code is new for 16)