-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Feature: Content Workspace Icon #19292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the Content Workspace Icon feature by adding content type icon observables to workspace contexts and rendering an icon in all workspace headers across members, media, and documents. Key changes include:
- Adding new observable properties (contentTypeIcon) to workspace context classes.
- Updating split-view elements to observe and render icons using the new observable and the ifDefined directive.
- Modifying scaffold creation in server data sources to merge in the new icon values.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/members/member/workspace/member/member-workspace.context.ts | Adds icon observable for member content type. |
| src/Umbraco.Web.UI.Client/src/packages/members/member/workspace/member/member-workspace-split-view.element.ts | Updates split-view element to observe icon and render . |
| src/Umbraco.Web.UI.Client/src/packages/members/member/repository/detail/member-detail.server.data-source.ts | Merges member type icon into the scaffold via deep merge. |
| src/Umbraco.Web.UI.Client/src/packages/members/member-type/repository/... | Renames and re-exports member type detail data source and repository. |
| src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace.context.ts | Adds icon observable for media content type. |
| src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-split-view.element.ts | Updates media split-view element to observe icon and render . |
| src/Umbraco.Web.UI.Client/src/packages/media/media/repository/detail/media-detail.server.data-source.ts | Merges media type icon into the scaffold. |
| src/Umbraco.Web.UI.Client/src/packages/document(s)/... | Similar updates for document workspace context, split-view, and data source to use the icon observable. |
| src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view.element.ts | Adds a slot for icon rendering in the workspace header. |
| src/Umbraco.Web.UI.Client/src/packages/core/repository/detail/detail-data-source.interface.ts | Updates createScaffold type to use UmbDeepPartialObject for stronger typing. |
...I.Client/src/packages/members/member/workspace/member/member-workspace-split-view.element.ts
Outdated
Show resolved
Hide resolved
...braco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-split-view.element.ts
Outdated
Show resolved
Hide resolved
...I.Client/src/packages/documents/documents/workspace/document-workspace-split-view.element.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…om/umbraco/Umbraco-CMS into v16/feature/content-workspace-icon
The PR adds the Content Type icon to all Content Workspace headers to emphasize the connection between the opened item and the workspace content.