Skip to content

Conversation

@nielslyngsoe
Copy link
Member

Implement labels to avoid seeing the console warnings and fixing so we get some more labels

Copilot AI review requested due to automatic review settings May 6, 2025 12:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements labels for various entity action bundles to eliminate console warnings and improve label consistency. Key changes include adding a "name" property to the value object in multiple collection view components, updating the label rendering to use localized terms, and modifying dropdown and entity action components to support the new label structure.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/packages/user/.../user-table-collection-view.element.ts Added "name: user.name" to the payload.
src/packages/user-group/.../user-group-table-collection-view.element.ts Added "name: userGroup.name" to the payload.
src/packages/members/.../member-table-collection-view.element.ts Added "name: member.name" to the payload.
src/packages/members/.../member-group-table-collection-view.element.ts Added "name: memberGroup.name" to the payload.
src/packages/media/.../media-table-collection-view.element.ts Added "name: item.name" to the payload.
src/packages/media-types/.../media-type-tree-item-table-collection-view.element.ts Added "name: item.name" to the payload.
src/packages/language/.../language-table-collection-view.element.ts Added "name: language.name" to the payload.
src/packages/extension-insights/.../extension-table-collection-view.element.ts Added "name: extension.name" to the payload.
src/packages/documents/.../document-entity-actions-table-column-view.element.ts Left a TODO comment regarding missing name handling.
src/packages/documents/.../document-type-tree-item-table-collection-view.element.ts Added "name: item.name" to the payload.
src/packages/data-type/.../data-type-tree-item-table-collection-view.element.ts Added "name: item.name" to the payload.
src/packages/core/tree/.../tree-item-element-base.ts Replaced inline label extraction with a localized _label property.
src/packages/core/menu/section-sidebar-menu-with-entity-actions.element.ts Updated label to a localized term using manifest meta label.
src/packages/core/menu/components/menu-item-layout.element.ts Updated label to a localized term using the current label property.
src/packages/core/entity-action/global-components/entity-actions-table-column-view.element.ts Extended the union type and updated label rendering but used a type cast for name.
src/packages/core/components/entity-actions-bundle/entity-actions-bundle.element.ts Added label to the dropdown and action list elements.
src/packages/core/components/dropdown/dropdown.element.ts Modified label property to be optional and provided a fallback value.
src/packages/clipboard/clipboard-entry/picker/clipboard-entry-picker.element.ts Updated label to be rendered as a localized term.
src/assets/lang/en.ts & da-dk.ts Added localized functions for "viewActionsFor".
Comments suppressed due to low confidence (1)

src/Umbraco.Web.UI.Client/src/packages/core/entity-action/global-components/entity-actions-table-column-view.element.ts:17

  • Instead of using a type cast with 'as any', consider refining the type definition for 'value' (e.g. using UmbNamedEntityModel) and implementing a proper type guard to access the name property.
label=${this.localize.term('actions_viewActionsFor', [(this.value as any).name])}>

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) May 6, 2025 12:35
@nielslyngsoe nielslyngsoe merged commit 0e73c54 into release/16.0 May 9, 2025
23 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/hotfix/implement-label-for-entity-actions-bundle branch May 9, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants