-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Split "Sort Children"-logic to remove "illegal" import from core to packages #19105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the sorting functionality for content children to remove illegal dependencies from core modules and introduce a dedicated "sortChildrenOfContent" action for content items.
- Splits the sort children action by moving content-specific logic into a separate entity action and modal.
- Enhances the UmbTable element with a new "sortable" mode that enables drag‐and‐drop with associated visual feedback.
- Adjusts module dependency checks by lowering the ILLEGAL_CORE_IMPORTS_THRESHOLD to tighten the allowed number of illegal core imports.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/packages/core/tree/entity-actions/sort-children-of/constants.ts | Adds new export for sort children action kind manifest. |
| src/packages/core/components/table/table.element.ts | Refactors table element to integrate sorting via UmbSorterController and new sortable attributes/styles. |
| src/packages/content/* | Introduces new content tree types, sort children action, modal elements, and manifests for content sorting. |
| src/devops/module-dependencies/index.js | Lowers the allowed illegal core imports threshold from 6 to 5. |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/devops/module-dependencies/index.js:5
- Verify that lowering ILLEGAL_CORE_IMPORTS_THRESHOLD from 6 to 5 is an intentional change, as this stricter threshold might result in unexpected errors if any core module currently relies on a higher number of package imports.
const ILLEGAL_CORE_IMPORTS_THRESHOLD = 5;
nielslyngsoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good, just need to verify that it actually works.
This PR refactors the sort-children-of entity action to eliminate the dependency on the
documentandmediamodules from the package. The PR introduces asortChildrenOfContententity action kind that manages the additional orderBynameandcreateDatelogic.Additional code changes
umb-tableelement instead of a custom table. This helps align the UI and provides a common interface for describing table columns and rows. ThesortChildrenOfContentuses this to add additional columns to the defaultsortChildrenOfaction.sortableattribute to theumb-tableelement that sets the table into asortingmode. This makes all rows draggable, and an event is emitted when the sorting is finished.Breaking Changes / Behaviour:
sortChildrenOfentity action now only allows manual drag and drop to change the sort ordercreateDate. This now has the same functionality hassortChildrenOfhad before.