Skip to content

Conversation

@enkelmedia
Copy link
Contributor

Fixes #19086 by adding a variable for top.

@github-actions
Copy link

github-actions bot commented Apr 21, 2025

Hi there @enkelmedia, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard iOvergaard changed the title Fixes #19086 by making top position a variable Tiptap cannot set the top position of the toolbar May 5, 2025
@iOvergaard iOvergaard merged commit 12049e9 into umbraco:contrib May 5, 2025
23 checks passed
@enkelmedia
Copy link
Contributor Author

@iOvergaard or @nielslyngsoe I've noticed that this is targeted for 16.1, quite a simple fix that is valuable for package devs that is using Tiptap, would it be possible to merge into v16/release for the next RC?

leekelleher pushed a commit that referenced this pull request Jun 2, 2025
* Fixes #19086 by making top position a variable

* #19086 Added JSDoc for cssprops

(cherry picked from commit 12049e9)
@leekelleher
Copy link
Member

leekelleher commented Jun 2, 2025

Cherry picked for 16.0 (rc5) in commit ebe93fb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tiptap: Scrolling issue in custom section

5 participants