-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Tiptap cannot set the top position of the toolbar #19087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there @enkelmedia, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/tiptap-toolbar.element.ts
Show resolved
Hide resolved
|
@iOvergaard or @nielslyngsoe I've noticed that this is targeted for 16.1, quite a simple fix that is valuable for package devs that is using Tiptap, would it be possible to merge into v16/release for the next RC? |
|
Cherry picked for 16.0 (rc5) in commit ebe93fb. |
Fixes #19086 by adding a variable for
top.