Skip to content

Conversation

@madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Apr 15, 2025

This element depends on a data type, so it can not live in the core package. This PR moves the element to the content-type module and makes the name more explicit, as it should only be used in content types (document type and media type).

Breaking Changes

  • Rename input-collection-configuration element to input-content-type-collection-configuration
  • Rename class UmbInputCollectionConfigurationElement to UmbInputContentTypeCollectionConfigurationElement
  • Move export of UmbInputContentTypeCollectionConfigurationElement from @umbraco-cms/backoffice/components to @umbraco-cms/backoffice/content-type

Copilot AI review requested due to automatic review settings April 15, 2025 07:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/devops/module-dependencies/index.js:5

  • Verify that reducing the ILLEGAL_CORE_IMPORTS_THRESHOLD from 7 to 6 is intentional and that it doesn't lead to unexpected import error reports.
const ILLEGAL_CORE_IMPORTS_THRESHOLD = 6;

src/Umbraco.Web.UI.Client/src/packages/content/content-type/global-components/input-content-type-collection-configuration/input-content-type-collection-configuration.element.ts:125

  • The default export for the legacy component was removed; please ensure that all consuming code has been updated to use the named export for UmbInputContentTypeCollectionConfigurationElement to avoid runtime issues.
declare global { interface HTMLElementTagNameMap { 'umb-input-content-type-collection-configuration': UmbInputContentTypeCollectionConfigurationElement; } }

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) April 15, 2025 08:53
@nielslyngsoe nielslyngsoe merged commit e6ab1d9 into v16/dev Apr 15, 2025
18 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/bugfix/rename-input-collection-confg-element branch April 15, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants