-
Notifications
You must be signed in to change notification settings - Fork 2.8k
V15: Revert "Fix: RTE markup props not up to date issue" #18879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Revert "Fix: RTE markup props not up to date issue" #18879
Conversation
This reverts commit 347e898.
cherry-picked from c03a8af Co-authored-by: Niels Lyngsø <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts a previous fix to address a regression affecting RTE markup props. The changes restore previous behavior in multiple components by reintroducing the use of the original markup values.
- Reverts the change in the tinyMCE property editor component to use an internal _latestMarkup variable.
- Removes an equality check from the TinyMCE input component’s value setter.
- Replaces comparisons of _markup with _latestMarkup in the RTE base component.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/tiny-mce/property-editors/tiny-mce/property-editor-ui-tiny-mce.element.ts | Reverts to storing and applying the latest markup using _latestMarkup |
| src/Umbraco.Web.UI.Client/src/packages/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts | Removes an early return check in the value setter |
| src/Umbraco.Web.UI.Client/src/packages/rte/components/rte-base.element.ts | Updates comparisons to use _latestMarkup and initializes new properties |
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/src/packages/tiny-mce/property-editors/tiny-mce/property-editor-ui-tiny-mce.element.ts:42
- [nitpick] The inline comment appears ambiguous regarding whether to retrieve the markup via doc.body.innerHTML or another method. Consider clarifying or removing the comment to prevent confusion.
// maybe in this way doc.body.innerHTML;
src/Umbraco.Web.UI.Client/src/packages/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts:63
- Removing the equality check may lead to unnecessary updates if the new value is the same as the current one. Consider reintroducing the check if its purpose was to prevent redundant processing.
if (newValue === this.value) return;
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that having checked out this branch, rebuilt and run I no longer see the issue.
Applied fixes from umbraco/Umbraco-CMS#18879
Description
This fixes a regression introduced by #18430 and reported in #18795
Fixes #18795