Skip to content

Conversation

@iOvergaard
Copy link
Contributor

Description

This fixes a regression introduced by #18430 and reported in #18795

Fixes #18795

iOvergaard and others added 2 commits March 31, 2025 10:36
Copilot AI review requested due to automatic review settings March 31, 2025 08:37
@iOvergaard iOvergaard review requested due to automatic review settings March 31, 2025 08:37
@iOvergaard iOvergaard enabled auto-merge (squash) March 31, 2025 08:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous fix to address a regression affecting RTE markup props. The changes restore previous behavior in multiple components by reintroducing the use of the original markup values.

  • Reverts the change in the tinyMCE property editor component to use an internal _latestMarkup variable.
  • Removes an equality check from the TinyMCE input component’s value setter.
  • Replaces comparisons of _markup with _latestMarkup in the RTE base component.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Umbraco.Web.UI.Client/src/packages/tiny-mce/property-editors/tiny-mce/property-editor-ui-tiny-mce.element.ts Reverts to storing and applying the latest markup using _latestMarkup
src/Umbraco.Web.UI.Client/src/packages/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts Removes an early return check in the value setter
src/Umbraco.Web.UI.Client/src/packages/rte/components/rte-base.element.ts Updates comparisons to use _latestMarkup and initializes new properties
Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/src/packages/tiny-mce/property-editors/tiny-mce/property-editor-ui-tiny-mce.element.ts:42

  • [nitpick] The inline comment appears ambiguous regarding whether to retrieve the markup via doc.body.innerHTML or another method. Consider clarifying or removing the comment to prevent confusion.
// maybe in this way doc.body.innerHTML;

src/Umbraco.Web.UI.Client/src/packages/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts:63

  • Removing the equality check may lead to unnecessary updates if the new value is the same as the current one. Consider reintroducing the check if its purpose was to prevent redundant processing.
if (newValue === this.value) return;

@iOvergaard iOvergaard disabled auto-merge March 31, 2025 08:39
@iOvergaard iOvergaard enabled auto-merge (squash) March 31, 2025 08:40
@iOvergaard iOvergaard requested a review from nielslyngsoe March 31, 2025 08:41
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that having checked out this branch, rebuilt and run I no longer see the issue.

@iOvergaard iOvergaard merged commit 98e0615 into release/15.3.1 Mar 31, 2025
23 checks passed
@iOvergaard iOvergaard deleted the v15/bugfix/tinymce-chars-regression branch March 31, 2025 11:13
leekelleher added a commit to leekelleher/umbraco-tinymce that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants