Skip to content

Conversation

@AndyButland
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Resolves issues #17725 and #17628

Description

Both issues linked look to stem from a change of a data type's property editor to something incompatible. When you do that, and the CMS attempts to retrieve references, it throws an exception. The exception is expected, but given references aren't a critical feature, we should log and move on, so as not to prevent more important actions like saving, publishing and deleting the content item.

So this PR is just a try/catch/log and move on.

To Test - see "Steps to reproduce" on #17725

…'t block critical operations following an incompatible data type change.
@AndyButland AndyButland requested a review from Migaroez March 5, 2025 09:54
@AndyButland
Copy link
Contributor Author

I've added a little more detail to the log message @Migaroez - but not sure I really could or should do more. Ideally here of course we'd tell you want property alias and document ID this was on, but we don't have that accessible. In particularly there's some grouping by property editor alias done to make the process of gathering references more performant, but in doing that we've got values from potentially several properties, and no longer know which one each value came from.

@Migaroez Migaroez merged commit 3f10bd8 into v15/dev May 19, 2025
21 checks passed
@Migaroez Migaroez deleted the v15/bugfix/get-reference-exception-handling branch May 19, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants