Skip to content

Help Header App, popover placement + code tidy-up #18329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iOvergaard merged 1 commit into from
Feb 14, 2025
Merged

Help Header App, popover placement + code tidy-up #18329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 10 additions & 22 deletions src/Umbraco.Web.UI.Client/src/packages/help/header-app/help-header-app.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
import { UMB_HELP_MENU_ALIAS } from '../menu/index.js';
import type { CSSResultGroup } from '@umbraco-cms/backoffice/external/lit';
import { css, html, customElement, state, nothing } from '@umbraco-cms/backoffice/external/lit';
import { UmbHeaderAppButtonElement } from '@umbraco-cms/backoffice/components';
import { customElement, html, nothing, state } from '@umbraco-cms/backoffice/external/lit';
import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
import type { ManifestMenu } from '@umbraco-cms/backoffice/menu';
import { UmbExtensionsManifestInitializer } from '@umbraco-cms/backoffice/extension-api';
import { UmbHeaderAppButtonElement } from '@umbraco-cms/backoffice/components';
import type { ManifestMenu } from '@umbraco-cms/backoffice/menu';

const elementName = 'umb-help-header-app';
@customElement(elementName)
@customElement('umb-help-header-app')
export class UmbHelpHeaderAppElement extends UmbHeaderAppButtonElement {
@state()
private _popoverOpen = false;

@state()
private _helpMenuHasMenuItems = false;

Expand All @@ -30,49 +25,42 @@ export class UmbHelpHeaderAppElement extends UmbHeaderAppButtonElement {
);
}

#onPopoverToggle(event: ToggleEvent) {
// TODO: This ignorer is just neede for JSON SCHEMA TO WORK, As its not updated with latest TS jet.
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
this._popoverOpen = event.newState === 'open';
}

override render() {
return html` ${this.#renderButton()} ${this.#renderPopover()} `;
return html`${this.#renderButton()} ${this.#renderPopover()}`;
}

#renderButton() {
if (!this._helpMenuHasMenuItems) return nothing;

return html`
<uui-button popovertarget="help-menu-popover" look="primary" label="help" compact>
<uui-button compact label=${this.localize.term('general_help')} look="primary" popovertarget="help-menu-popover">
<uui-icon name="icon-help-alt"></uui-icon>
</uui-button>
`;
}

#renderPopover() {
return html`
<uui-popover-container id="help-menu-popover" @toggle=${this.#onPopoverToggle}>
<uui-popover-container id="help-menu-popover" placement="top-end">
<umb-popover-layout>
<uui-scroll-container>
<umb-extension-slot
type="menu"
.filter="${(menu: ManifestMenu) => menu.alias === UMB_HELP_MENU_ALIAS}"
.filter=${(menu: ManifestMenu) => menu.alias === UMB_HELP_MENU_ALIAS}
default-element="umb-menu"></umb-extension-slot>
</uui-scroll-container>
</umb-popover-layout>
</uui-popover-container>
`;
}

static override styles: CSSResultGroup = [UmbHeaderAppButtonElement.styles, css``];
static override styles = UmbHeaderAppButtonElement.styles;
}

export { UmbHelpHeaderAppElement as element };

declare global {
interface HTMLElementTagNameMap {
[elementName]: UmbHelpHeaderAppElement;
'umb-help-header-app': UmbHelpHeaderAppElement;
}
}
Loading