Feature: Tree expansion state #18227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/tree/entity-actions/move/move-to.action.ts
src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/tree/expansion-manager/tree-expansion-manager.ts
Outdated
Show resolved
Hide resolved
...raco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-context-base.ts
Outdated
Show resolved
Hide resolved
nielslyngsoe
requested changes
Mar 19, 2025
Member
nielslyngsoe
left a comment
nielslyngsoe
left a comment
There was a problem hiding this comment.
Just a few comments that improves the readability of the code and one optional comment on optimization. It works as expected, but I think the not-optimization comments should be corrected first :-)
nielslyngsoe
approved these changes
Mar 24, 2025
This was referenced Sep 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17557
This PR marks the first step in maintaining the entire menu state in a section context. This initial step introduces a tree expansion manager that holds the state for a single tree. The tree items observe the expansion state and behave accordingly.
With this feature, we can also solve the problem described in the issue above, where a user has to expand the tree root when moving or duplicating an entity.
What to test: