Allow fetching multiple content and media by Guid and Udi

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

Description

In Angular it is possible to fetch content by int, Guid and Udi id using contentResource.getById(), but often it is better fetching multiple items in a single request instead of multiple requests.

and since most pickers stores udi references, then Guid and Udi overload methods are preferred. However contentResource.getByIds() only supported int ids.

Currently the ids are from querystring, but it may be better it post ids in body like entityResource.getByIds() method does.

I also updated this for media.

I found it is bit inconsistency that ContentService GetByIds(IEnumerable<Udi> ids) extension returns nullable, while MediaService GetByIds(IEnumerable<Udi> ids) extension doesn't

Umbraco-CMS/src/Umbraco.Core/Services/ContentServiceExtensions.cs

Lines 22 to 37 in e80d117

	public static IEnumerable<IContent>? GetByIds(this IContentService contentService, IEnumerable<Udi> ids)
	{
	var guids = new List<GuidUdi>();
	foreach (Udi udi in ids)
	{
	if (udi is not GuidUdi guidUdi)
	{
	throw new InvalidOperationException("The UDI provided isn't of type " + typeof(GuidUdi) +
	" which is required by content");
	}
	guids.Add(guidUdi);
	}
	return contentService.GetByIds(guids.Select(x => x.Guid));
	}

Umbraco-CMS/src/Umbraco.Core/Services/MediaServiceExtensions.cs

Lines 20 to 35 in e80d117

	public static IEnumerable<IMedia> GetByIds(this IMediaService mediaService, IEnumerable<Udi> ids)
	{
	var guids = new List<GuidUdi>();
	foreach (Udi udi in ids)
	{
	if (udi is not GuidUdi guidUdi)
	{
	throw new InvalidOperationException("The UDI provided isn't of type " + typeof(GuidUdi) +
	" which is required by media");
	}
	guids.Add(guidUdi);
	}
	return mediaService.GetByIds(guids.Select(x => x.Guid));
	}

[github-actions]

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[bjarnef]

@Zeegaan speaking about Guid and entities 😁

[bjarnef]

@nul800sebastiaan this one shouldn't have any impact on existing behavior, but allow GetByIds to be fetched by int[] (as now) + Guid[] and Udi[] - just like GetById accepting int, Guid and Udi.

The extensions could be streamlined in v14 (if not already).

[bjarnef]

@AndyButland would it still make sense the include this in latest v13?

I recall in some custom views, where it would have been useful with a single lookup, but I needed to make a lookup per item (or create a custom API method to handle that).

[AndyButland]

My guess is there's not too much demand given the time this PR has been pending, but I don't see any harm in it and can see it might allow some optimisations for packages doing these look-ups. Will merge in and schedule for 13.12 (13.11 is already built and internally tested, so I don't want to add more to that).