Removing a node from a Multinode Treepicker removes the wrong node in a certain context

[g-rahman]

Which Umbraco version are you using?

13.11.0

Bug summary

When a multinode treepicker contains references to one or more nodes that no longer exist, any attempt to remove nodes that are low on the picker's list (below the deleted node) cause the wrong node to be removed from the list.

Specifics

When a multinode treepicker contains references to one or more nodes that no longer exist, those nodes do not appear in the UI of the backend. When a user attempts to remove a node from the list of selected nodes, the UI appears to use an index-based removal process, but the index it passes is based on the number of existing nodes, not the total number of nodes referenced by the control. On the other hand, the code that performs the deletion uses the full list of node references, deleted nodes included. This discrepancy means that the wrong node is removed from the picker.

Steps to reproduce

1. Create a doctype of "Location" and build 4 locations (e.g. Location A - D).
2. Create a doctype of "Basic" containing a property of "Locations" which is a property of type Multinode Treepicker.
3. Creates a "Basic" node and populate the "Locations" property with all 4 locations.
4. Delete the second Location node -- the actual node, not its reference in the picker -- (e.g. Location B) and empty the Trash.
5. Revisit the "Locations" property on the "Basic" node; the list should now show 3 locations (e.g. Location A, C, and D).
6. Attempt to remove the last location (e.g. Location D) from the picker.

Expected result / actual result

I expect the last location to disappear from the picker. Instead, the next-to-last location disappears.

Note that the first location (Location A) could be accurately removed in this scenario. Further, if the second location (Location C) were clicked, it would actually remove the invisible reference to the deleted location (Location B) with no apparent change to the list in the UI.

I propose that the remove function is updated to reference the specific node key (GUID) rather than the index, so that the removal process can accurately remove the proper node.

[github-actions]

Hi there @g-rahman!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[leekelleher]

Fixed in #20950, for Umbraco v13.13.0.

[g-rahman]

Thanks, guys!