Proposed workaround to mute sed error in certain OS #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroeder-g
approved these changes
Jul 23, 2025
Contributor
schroeder-g
left a comment
schroeder-g
left a comment
There was a problem hiding this comment.
approving to remove any block here!
|
|
||
| # if this script is editing the ID of your recipe file, uncomment the line above and comment out the line below | ||
| # sed -i '' "s/\"id\"[[:space:]]*:[[:space:]]*\"$ID_VALUE\"/\"id\": \"$NEW_ID\"/" "${FLOW}/metadata.json" | ||
| # if you're getting `sed: 1: "...": invalid command code f` use the line above |
Contributor
There was a problem hiding this comment.
I've been grappling with sed -i '' since switching to mac, ngl.
An alternative here would be that we can check to see which os we're on automatically, like uname -s to get Darwin, and if so, continue with the current implementation.
Curious to know in what context you were running into issues here? I thought everyone was running on mac and so I'd have expected the sed -i to work as one would hope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.