Skip to content

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Apr 17, 2018

No description provided.

@ucbjrl ucbjrl requested review from chick and edwardcwang April 17, 2018 21:03
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
One question about val n

* @param n is the number of fanned outputs for the routed packet
*/
class RouterIO(n: Int) extends Bundle {
class RouterIO(val n: Int) extends Bundle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious as to why this became a val, I can't see a reference to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto clone type (rightly) complains about bundle parameters that aren't immutable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks.

@ucbjrl ucbjrl merged commit 06ae117 into master Apr 18, 2018
@ucbjrl ucbjrl deleted the updatedeprecated branch April 18, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants