-
Notifications
You must be signed in to change notification settings - Fork 27
feat:added profile functionality #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat:added profile functionality #272
Conversation
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
|
I think you've got to update for 3.13, change to vs. in pfb.py and users.py at least I had to for it to work. Double check that also works in 3.9 and if there's a way to support both, let's do it |
Avantol13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to refactor some of the stuff here - the profile listing support it's polluting the top level commands.
Let's see if we can just move those under configure. e.g.
instead of top level commands, let's do this:
gen3 configure list-profiles
gen3 configure show-profile --profile MIDRC_prod
and then the existing:
gen3 configure --profile new_profile ...
New Features