Add dev/setup binstubs to more easily setup and dev on local #3238
Conversation
| # Install JavaScript dependencies | ||
| # system('bin/yarn') | ||
| puts "\n== Install JavaScript dependencies ==" | ||
| system('yarn check --check-files') || system!('yarn install') |
There was a problem hiding this comment.
We use yarn and docker in our application, add them to our bin/setup
There was a problem hiding this comment.
Is this the recommended way to setup? Should we update our README?
There was a problem hiding this comment.
Yeah good call out. Let's update the README. Can make a change for this in this PR 👍
There was a problem hiding this comment.
Added and cleanup sections in readme to reference these new binstubs instead
bin/update
Outdated
There was a problem hiding this comment.
This file has been removed in Rails. As bin/setup is idempotent, and you could just use this instead
murny
requested review from
ConnorSheremeta,
jefferya,
lagoan and
pgwillia
as code owners
murny
force-pushed
the
add-setup-dev-bin-stubs
branch
from
51a8ef8 to
9a025ea
Compare
| @@ -1,3 +1,3 @@ | |||
| app: bin/rails s -p 3000 | |||
| web: env RUBY_DEBUG_OPEN=true bin/rails server | |||
There was a problem hiding this comment.
I haven't seen RUBY_DEBUG_OPEN before. How are you using it?
There was a problem hiding this comment.
I believe with foreman you can't access your debugger inside the process as you don't have proper TTY available. Overmind has ways around this, which is why I prefer it, amongst other reasons. But if we can get foreman working nicely too why not?
This came from the default Rails generator in version 7+ from these gems:
rails/jsbundling-rails#146
rails/cssbundling-rails#123
These PRs say:
"When running inside foreman the 'debug' gem will not have a proper TTY available. Running with the --open option enabled allows to start remote sessions and attach a debugger client with rdbg --attach.
More info: https://github.com/ruby/debug#invoke-as-a-remote-debuggee"
Rails provides helpful
bin/dev(in rails 7+) andbin/setupbinstubs to help developers start their project and run their applications.Let's update ours so they work with our stack
(note: bin/update is no longer a thing in latest verions of rails so we can remove this)