-
Notifications
You must be signed in to change notification settings - Fork 14
Partial document struct for updates #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RoDmitry
wants to merge
40
commits into
typesense:main
Choose a base branch
from
haydenhoang:partial_document
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: missing generic in impl block
… plain text (JSONL)
…and remove unused templates
ce92a1f
to
8e44901
Compare
8e44901
to
365c353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generates a partial document struct for updates. To avoid
serde_json::Value
as an input.Derive macro creates
struct BookPartial
with all optional fields.@haydenhoang what do you think? Need help with deciding about
collection_schemaless
tests (intypesense/tests/client/documents_test.rs
). Do you needcollection_schemaless
updates and creates? As you know I hateserde_json::Value
. Is there any point in implementing it?Also I don't know if
id
is updatable.And is there a reason to have
Option<Option<bool>>
for updates, or should it beOption<bool>
?