Skip to content

Nightly Builds 검토 및 수정 (resolve #55) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2020
Merged

Nightly Builds 검토 및 수정 (resolve #55) #90

merged 2 commits into from
Jun 10, 2020

Conversation

guyeol
Copy link
Member

@guyeol guyeol commented Jun 9, 2020

리뷰 부탁드립니다

resolves #55

@guyeol guyeol added the 🚀 번역중 번역을 진행하고 있어요 label Jun 9, 2020
@guyeol guyeol added this to the v1 번역 milestone Jun 9, 2020
@guyeol guyeol requested review from bumkeyy, yeonjuan and dvlprsh June 9, 2020 04:28
@guyeol guyeol self-assigned this Jun 9, 2020
dvlprsh
dvlprsh approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@dvlprsh dvlprsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

bumkeyy
bumkeyy reviewed Jun 10, 2020
View reviewed changes
@bumkeyy
Copy link
Member

bumkeyy commented Jun 10, 2020

@guyeol @dvlprsh @yeonjuan

tool을 도구로 번역하면 조금 어색한 감이 있는데 그냥 툴로 사용하는 건 어떨까요?

@dvlprsh
Copy link
Member

dvlprsh commented Jun 10, 2020

@bumkeyy

tool을 도구로 번역하면 조금 어색한 감이 있는데 그냥 툴로 사용하는 건 어떨까요?

동의합니다~ 툴로 사용하는게 더 자연스러운거 같아요 :)

yeonjuan
yeonjuan approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 고생하셨습니다.

@yeonjuan yeonjuan merged commit 8c7e191 into master Jun 10, 2020
@yeonjuan yeonjuan deleted the issue55/nightly_builds branch June 10, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumkeyy bumkeyy bumkeyy left review comments

@yeonjuan yeonjuan yeonjuan approved these changes

@dvlprsh dvlprsh dvlprsh approved these changes

Assignees

@guyeol guyeol

Labels
🚀 번역중 번역을 진행하고 있어요
Projects
None yet
Milestone
v1 번역
Development

Successfully merging this pull request may close these issues.

Project Configuration / Nightly Builds 번역
4 participants
@guyeol @bumkeyy @dvlprsh @yeonjuan