translate: Dom Manipulation(~ end) #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first translation(9/7) * 2차 검토, 맞춤법검사, lint 검사(9/8) * 오타 재검토
Closed
guyeol
reviewed
Sep 9, 2020
guyeol
reviewed
Sep 9, 2020
|
몇 가지 제안 남겨두었습니다 |
* 제안 반영 Co-authored-by: GuyeolJeong <[email protected]>
* 제안 반영 Co-authored-by: GuyeolJeong <[email protected]>
제안해주신 내용 확인했습니다! 번역 누락까지 지적 감사합니다! |
bumkeyy
reviewed
Sep 10, 2020
bumkeyy
reviewed
Sep 10, 2020
bumkeyy
reviewed
Sep 10, 2020
* 코드 리뷰 제안 반영 Co-authored-by: Kibeom Kwon <[email protected]>
* 제안반영 Co-authored-by: Kibeom Kwon <[email protected]>
* 제안반영 Co-authored-by: Kibeom Kwon <[email protected]>
말씀해주신 제안사항이 매끄러워 모두 반영했습니다!🙇🏻♀️ |
* line 197 번역 누락 수정
dvlprsh
reviewed
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR전에 아래의 사항들을 확인하셨나요? 확인하셨다면, 체크해주세요!
PR에 대한 간단한 내용 설명을 부탁드립니다!
(ref: Dom Manipulation 번역 #117) Dom Manipulation @sooyun429 님이 맡으신 부분 이후부터 끝까지 번역 진행하였습니다.
번역 리뷰시 중점적으로 봐주셨으면 하는 부분 함께 첨부하겠습니다.
Node,Element인터페이스에 대한 이야기가 중점적으로 많이 등장하는데, 이 부분은 인터페이스명 그대로 표기하였습니다. 중간중간에 인터페이스를 지칭하는 것이 아닌 것 같은 부분은 노드, 요소로 번역했으니 이 부분에 대해 적절치 못한 부분이 있으면 의견 부탁드립니다!line137의 After capturing thedivelement 부분과line178에 의역한 부분이 조금 있어서 중점적으로 봐주시면 좋을 것 같습니다!