Skip to content

Enhancement: [rule-tester] remove spurious dependency on @eslint/eslintrc #9785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
jakebailey opened this issue Aug 12, 2024 · 1 comment · Fixed by #9786
Closed
4 tasks done

Enhancement: [rule-tester] remove spurious dependency on @eslint/eslintrc #9785

jakebailey opened this issue Aug 12, 2024 · 1 comment · Fixed by #9786
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: rule-tester Issues related to the @typescript-eslint/rule-tester package repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@jakebailey
Copy link
Collaborator

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

rule-tester

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

In microsoft/TypeScript#59518 I was updating TS to use ESLint v9 and typescript-eslint v8. I noticed in the lockfile that @eslint/eslintrc was present even though I didn't depend on it. npm why @eslint/eslintrc gave me:

@eslint/[email protected] dev
node_modules/@eslint/eslintrc
  peer @eslint/eslintrc@">=2" from @typescript-eslint/[email protected]
  node_modules/@typescript-eslint/rule-tester
    dev @typescript-eslint/rule-tester@"^8.1.0" from the root project
  @eslint/eslintrc@"^3.1.0" from [email protected]
  node_modules/eslint
    dev eslint@"^9.9.0" from the root project

My reading of this is that eslint itself still depends on this, so it can't go away, but I didn't realize this at the time and thought @typescript-eslint/rule-tester may be the only reason we had it. Searching though the package, I noticed that it never uses @eslint/eslintrc, so the dep could actually just be removed without any changes.

Filing an issue since I think you require one before sending a PR.

Additional Info

No response

@jakebailey jakebailey added enhancement New feature or request triage Waiting for team members to take a look labels Aug 12, 2024
@auvred
Copy link
Member

auvred commented Aug 13, 2024

@bradzacher bradzacher added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue package: rule-tester Issues related to the @typescript-eslint/rule-tester package and removed enhancement New feature or request triage Waiting for team members to take a look labels Aug 13, 2024
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Aug 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: rule-tester Issues related to the @typescript-eslint/rule-tester package repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@jakebailey @bradzacher @auvred and others