Skip to content

Fix invalid indent rule when using tabs #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fix invalid indent rule when using tabs #720

merged 1 commit into from
Sep 17, 2020

Conversation

kuzivany
Copy link
Contributor

@kuzivany kuzivany commented Sep 17, 2020 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Fixes the ESLint converter when using the "tabs" option in the indent rule as stated here

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8595d7d into typescript-eslint:main Sep 17, 2020
@KingDarBoja KingDarBoja added good first issue Good for newcomers; welcome aboard! and removed good first issue Good for newcomers; welcome aboard! labels Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

converting tslint.indent to eslint.@typescript-eslint/indent should also convert occurances of tabs to tab

3 participants

@kuzivany @JoshuaKGoldberg @KingDarBoja