Skip to content

Stopped writing empty root members in output configurations #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2020
Merged

Stopped writing empty root members in output configurations #539

merged 1 commit into from
May 9, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Cleans up the output configuration format a little bit to not redundantly print empty objects. Just a little cleanup 🧹

KingDarBoja
KingDarBoja approved these changes May 9, 2020
View reviewed changes
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spicy util function 🌶️ pretty much what I was thinking to solve this issue 😆

@JoshuaKGoldberg
Copy link
Member Author

great minds think alike

@JoshuaKGoldberg JoshuaKGoldberg merged commit b165a6b into master May 9, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-output-empty-root-members branch May 9, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Empty objects from extended configurations are added to output ESLint configurations

2 participants

@JoshuaKGoldberg @KingDarBoja