Skip to content

Fix arrow-parens converter #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Fix arrow-parens converter #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/rules/converters/arrow-parens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import { RuleConverter } from "../converter";

export const convertArrowParens: RuleConverter = tslintRule => {
const ruleArguments = [
tslintRule.ruleArguments.length !== 0 && tslintRule.ruleArguments[0] === "always"
? "always"
: "as-needed",
tslintRule.ruleArguments.length !== 0 &&
tslintRule.ruleArguments[0] === "ban-single-arg-parens"
? "as-needed"
: "always",
];

return {
Expand Down
19 changes: 2 additions & 17 deletions src/rules/converters/tests/arrow-parens.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,6 @@ describe(convertArrowParens, () => {
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleArguments: ["as-needed"],
ruleName: "arrow-parens",
},
],
});
});

test("conversion with an always argument", () => {
const result = convertArrowParens({
ruleArguments: ["always"],
});

expect(result).toEqual({
rules: [
{
Expand All @@ -31,9 +16,9 @@ describe(convertArrowParens, () => {
});
});

test("conversion with an as-needed argument", () => {
test("conversion with a ban-single-arg-parens argument", () => {
const result = convertArrowParens({
ruleArguments: ["as-needed"],
ruleArguments: ["ban-single-arg-parens"],
});

expect(result).toEqual({
Expand Down