Skip to content

No longer extend from removed/deprected Prettier ESLint configs #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2022
Merged

No longer extend from removed/deprected Prettier ESLint configs #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/converters/lintConfigs/reporting/reportConfigConversionResults.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { createEmptyConfigConversionResults } from "../configConversionResults.s
import { ESLintRuleOptions } from "../rules/types";
import { reportConfigConversionResults } from "./reportConfigConversionResults";

const basicExtends = ["prettier", "prettier/@typescript-eslint"];
const basicExtends = ["prettier"];

describe("reportConfigConversionResults", () => {
it("logs a successful conversion without notices when there is one converted rule without notices", async () => {
Expand Down
4 changes: 0 additions & 4 deletions src/converters/lintConfigs/summarization/retrieveExtendsValues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ const builtInExtensions = new Map([

const pluginExtensions = new Map([
["eslint-plugin-prettier", "node_modules/eslint-config-prettier/index.js"],
[
"eslint-plugin-prettier/@typescript-eslint",
"node_modules/eslint-config-prettier/@typescript-eslint.js",
],
[
"plugin:@typescript-eslint/all",
"node_modules/@typescript-eslint/eslint-plugin/dist/configs/all.json",
Expand Down
2 changes: 1 addition & 1 deletion src/converters/lintConfigs/summarization/summarizePackageRules.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe("summarizePackageRules", () => {
expect(summarizedResults).toEqual({
...ruleConversionResults,
converted: new Map(),
extends: ["prettier", "prettier/@typescript-eslint"],
extends: ["prettier"],
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/converters/lintConfigs/summarization/summarizePackageRules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const summarizePackageRules = async (

// 3a. If no output rules conflict with `eslint-config-prettier`, it's added in
if (dependencies.checkPrettierExtension(ruleConversionResults, prettierRequested)) {
allExtensions.push("prettier", "prettier/@typescript-eslint");
allExtensions.push("prettier");
}

if (allExtensions.length === 0) {
Expand Down