refactor: replace custom HTTP client with GitHub API library when fetching installation token #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
krzema12
reviewed
Apr 7, 2025
krzema12
reviewed
Apr 7, 2025
shared-internal/src/main/kotlin/io/github/typesafegithub/workflows/shared/internal/GitHubApp.kt
Show resolved
Hide resolved
krzema12
reviewed
Apr 7, 2025
shared-internal/src/main/kotlin/io/github/typesafegithub/workflows/shared/internal/GitHubApp.kt
Show resolved
Hide resolved
krzema12
reviewed
Apr 7, 2025
shared-internal/src/main/kotlin/io/github/typesafegithub/workflows/shared/internal/GitHubApp.kt
Show resolved
Hide resolved
krzema12
reviewed
Apr 7, 2025
shared-internal/src/main/kotlin/io/github/typesafegithub/workflows/shared/internal/GitHubApp.kt
Outdated
Show resolved
Hide resolved
Simplified access token handling by leveraging `org.kohsuke:github-api` library, removing custom HTTP client and serialization logic.
Simplified access token handling by leveraging `org.kohsuke:github-api` library, removing custom HTTP client and serialization logic.
LeoColman
force-pushed
the
1884-use-a-lib-to-interact-with-github
branch
from
f62c271 to
27c3661
Compare
Simplified access token handling by leveraging `org.kohsuke:github-api` library, removing custom HTTP client and serialization logic.
krzema12
approved these changes
Apr 7, 2025
krzema12
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1884.
Simplified access token handling by leveraging
org.kohsuke:github-apilibrary, removing custom HTTP client and serialization logic.