Release 1.15.0

[ashawley]

In #667, @smarter said:

@non @ashawley once this is in, what do you think about releasing 1.15.0? According to #540 it was supposed to come shortly after 1.14.1. It'd be great to get it out for the improved dotty usability from finally getting rid of the ambiguous implicit error due to BooleanOperators.

[ashawley]

I agree we should release 1.15.0.

I've worked on applying the 1.15.0 label to open issues, so we can track progress and the remaining effort:

https://github.com/typelevel/scalacheck/milestone/10

[smarter]

How critical are the remaining issues in the 1.15.0 milestone? Could some of them be moved to a future milestone to release 1.15.0 faster ?

[larsrh]

Would be much appreciated. Happy to volunteer the time to upgrade the Typelevel ecosystem.

[SethTisue]

@ashawley are you around and interested in helping push this forward? (fsvo "helping")

[ashawley]

I should have free time soon to contribute to getting a release out here. Sorry for the delay.

[SethTisue]

note that one possibility would be to just close our eyes, roll whatever we have and call it 1.15.0-M1 (or 1.15.0-RC1), and then work towards 1.15.0 final after

thought prompted because I just hit "ambiguous implicit error due to BooleanOperators" myself today over at scala/scala-parallel-collections#113, so now I know what y'all are talking about there :-)

[non]

@SethTisue i'll do that this weekend

[non]

@SethTisue So, the Dotty build is blocking the release. Specifically, it appears it didn't build javadoc jars, which Sonatype checks for when validating the release. Here the publish output from Dotty:

[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1.pom.asc
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1-sources.jar.asc
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1.jar
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1.pom
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1.jar.asc
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1-sources.jar 

And here's Scala 2.12 (JVM):

[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1-javadoc.jar.asc                                                          
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1.pom.asc                                                                  
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1-sources.jar.asc                                                          
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1.jar                                                                      
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1.pom                                                                      
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1-javadoc.jar                                                              
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1.jar.asc                                                                  
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1-sources.jar

As you can see Dotty only published 6 files while 2.12 published 8.

I don't know a lot about how Dotty publishes. Is this expected? Is there some other SBT command I need to run for Dotty?

EDIT: I ran release.sh publishSigned which runs IS_RELEASE="true" sbt "+ jvm/publishSigned" (among other commands).

[smarter]

This comes from your sbt build:

scalacheck/build.sbt

Lines 170 to 174 in b296397

	publishArtifact in (Compile, packageDoc) := {
	// dotty-doc defect https://github.com/lampepfl/dotty/issues/7326
	!isDotty.value // ==> true
	// else ==> false
	},

The usual workaround to keep sonatype happy is to still publish a doc jar but leave it empty, this is accomplished by having in your sbt build:

sources in (Compile, doc) := Seq()

except here you only want to do it for dotty so you probably want:

sources in (Compile, doc) := {
  if (isDotty.value) then Seq() else (sources in (Compile, doc)).value
}

[non]

@smarter Thanks!

[smarter]

You could also turn off the dotty build for now: the scalacheck build is at version 0.24.0-RC1 so it's way too old to be useful currently anyway. You could try bumping it to 0.27.0-RC1 but that might require porting some commits from the version of scalacheck in our community build: https://github.com/dotty-staging/scalacheck/commits/a715860a25ad6d2c6e1ae17e8baa13ded427cdf0

[non]

@smarter I'll try with what I have since it's currently on and already running. If this build fails, I'll turn it off for now and we can revisit.

[non]

OK yeah the SBT snippet didn't totally work so I released without Dotty. We can try to fix this before the real 1.15.0 release.

[non]

Anyway, just released 1.15.0-M1.