Skip to content

#18 Rename filelocrepr to reprfileloc #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

laurentS
Copy link
Contributor

@laurentS laurentS commented Apr 7, 2020

Fixes a bug introduced with pytest >= 5.4.0 (specifically since pytest-dev/pytest#6739) which prevented pytest-mypy-plugins from running.

This change might require specifying the correct version of pytest in dependencies, I'm not sure what the best way to handle this is.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Just asking: can we pass this parameter without an explicit name?
So it will work on every pytest version.

This seems to work on pytest version 4.6.x up to 5.4.x (tested locally with python3.7)
@laurentS
Copy link
Contributor Author

laurentS commented Apr 7, 2020

That was a good idea! I just pushed an update that I've tested locally on a few different versions of pytest (see commit message)

@sobolevn sobolevn merged commit c5c052d into typeddjango:master Apr 7, 2020
@sobolevn
Copy link
Member

sobolevn commented Apr 7, 2020

Great! I will release this bugfix shortly.

@kornicameister
Copy link
Contributor

It just bite me ;].
Waiting for release to happen ;-)

griels pushed a commit to griels/pytest-mypy-plugins that referenced this pull request Dec 19, 2024
* typeddjango#18 Rename filelocrepr to reprfileloc

* Use positional arguments

This seems to work on pytest version 4.6.x up to 5.4.x (tested locally with python3.7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants