Use attrs with all Repr classes

[blueyed]

Follow-up to #6732.

[blueyed]

I assume we can go with s/filelocrepr/reprfileloc, or should it support the old name? (it was at least used internally).

[blueyed]

I assume we can go with s/filelocrepr/reprfileloc, or should it support the old name? (it was at least used internally).

Still an open question..

[nicoddemus]

I think it is OK to change the parameter name and keep the attribute reprfileloc: I doubt people create ReprEntry explicitly (it is not possible to import ReprEntry through the public API).

[bluetech]

LGTM, except the mixin class (I really dislike those!), which makes me wonder if there is particular reason you decided to break the ExceptionRepr subclassing? The following change on top of yours brings it back and seems to work fine:

diff --git a/src/_pytest/_code/code.py b/src/_pytest/_code/code.py
index 8c349c17e..2bf3b76fa 100644
--- a/src/_pytest/_code/code.py
+++ b/src/_pytest/_code/code.py
@@ -928,12 +928,8 @@ class TerminalRepr:
         raise NotImplementedError()
 
 
-class _SectionsRepr:
-    """Mixin for handling sections.
-
-    Only `ExceptionRepr` takes it in `__init__`, but others use it also.
-    """
-
+@attr.s
+class ExceptionRepr(TerminalRepr):
     def __attrs_post_init__(self):
         self.sections = []  # type: List[Tuple[str, str, str]]
 
@@ -947,12 +943,7 @@ class _SectionsRepr:
 
 
 @attr.s
-class ExceptionRepr(_SectionsRepr, TerminalRepr):
-    sections = attr.ib(type=List[Tuple[str, str, str]])
-
-
-@attr.s
-class ExceptionChainRepr(_SectionsRepr, TerminalRepr):
+class ExceptionChainRepr(ExceptionRepr):
     chain = attr.ib(
         type=Sequence[
             Tuple["ReprTraceback", Optional["ReprFileLocation"], Optional[str]]
@@ -976,7 +967,7 @@ class ExceptionChainRepr(_SectionsRepr, TerminalRepr):
 
 
 @attr.s
-class ReprExceptionInfo(_SectionsRepr, TerminalRepr):
+class ReprExceptionInfo(ExceptionRepr):
     reprtraceback = attr.ib(type="ReprTraceback")
     reprcrash = attr.ib(type="ReprFileLocation")
 

[blueyed]

@bluetech
I've pushed your patch, thanks!
It was necessary before __attrs_post_init__ was used only I guess.

[nicoddemus]

Awesome, thanks!

[nicoddemus]

I think it is OK to change the parameter name and keep the attribute reprfileloc: I doubt people create ReprEntry explicitly (it is not possible to import ReprEntry through the public API).