Skip to content

Fix encoder and decoder params on JSONField #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2022
Merged

Fix encoder and decoder params on JSONField #304

merged 1 commit into from
Dec 3, 2022

Conversation

zetahernandez
Copy link
Contributor

I have made things!

Related issues

params encoder and decoder on JSONField are class types.
Similar example on django_stubs
https://github.com/typeddjango/django-stubs/blob/b81b1bf3868eaab9fecebdd56ed817ffcb07fad8/django-stubs/db/models/fields/json.pyi#L14-L15

intgr
intgr approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Will merge after the CI fix PR is also merged.

@intgr intgr merged commit c6f9c7d into typeddjango:master Dec 3, 2022
@intgr
Copy link
Contributor

intgr commented Dec 3, 2022

Thanks! I rebased your branch just to verify CI and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr intgr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zetahernandez @intgr