Skip to content

Run different version of mypy in ci #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Run different version of mypy in ci #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
strategy:
matrix:
python-version: ['3.10', '3.11', '3.12', '3.13']
mypy-version: ['1.13', '1.14', '1.15', 'latest']
fail-fast: false
steps:
- uses: actions/checkout@v4
Expand All @@ -31,7 +32,12 @@ jobs:
- name: Install dependencies
run: |
pip install -U pip "setuptools<79.0.0" wheel
SETUPTOOLS_ENABLE_FEATURES=legacy-editable pip install -r ./requirements.txt
SETUPTOOLS_ENABLE_FEATURES=legacy-editable pip install -r ./requirements-base.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can keep old requirements.txt and add pip install -U "mypy==${{ matrix.mypy-version }}"

Copy link
Contributor Author

@UnknownPlatypus UnknownPlatypus May 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to avoid installing 2 versions of mypy to gain some ci time.

Anyways, this should be much easier to handle once we revive the project.toml PR, might do that later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly specifying multiple editable dependencies does not seem to be possible with a pyproject.toml file yet. From PEP 735:

Special attention was devoted to attempting to standardize the expression of editable installations, as expressed by pip install -e and PEP 660. However, although the creation of editable installs is standardized for build backends, the behavior of editables is not standardized for installers. Inclusion of editables in this PEP requires that any supporting tool allows for the installation of editables.
Therefore, although Poetry and PDM provide syntaxes for some of these features, they are considered insufficiently standardized at present for inclusion in Dependency Groups.

So I don't think we can completely remove the requirements.txt file without switching to something like uv.

I'll be happy to do that if you guys agree, it should also simplify the local setup to a simple uv sync command, making contributions easier.
wdyt @sobolevn @adamchainz ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, let's move to uv. current setup is broken for local development :(

if [ "${{ matrix.mypy-version }}" == "latest" ]; then
pip install git+https://github.com/python/mypy.git@master
else
pip install mypy==${{ matrix.mypy-version }}
fi

- name: Run mypy on plugin code
run: mypy --strict mypy_django_plugin
Expand Down
17 changes: 17 additions & 0 deletions requirements-base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Dev tools:
pytest==8.3.5
pytest-mypy-plugins==3.2.0
pytest-shard==0.1.2
pytest-xdist==3.6.1

# Needed by stubtest
mysqlclient==2.2.7

# Django deps:
psycopg2-binary
Django==5.2.1
-e ./ext
-e .[redis,compatible-mypy,oracle]

# Overrides:
pyright==1.1.400
16 changes: 1 addition & 15 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,4 @@
# Dev tools:
pytest==8.3.5
pytest-mypy-plugins==3.2.0
pytest-shard==0.1.2
pytest-xdist==3.6.1

# Needed by stubtest
mysqlclient==2.2.7

# Django deps:
psycopg2-binary
Django==5.2.1
-e ./ext
-e .[redis,compatible-mypy,oracle]
-r ./requirements-base.txt

# Overrides:
mypy==1.15.0
pyright==1.1.400
Loading