Run different version of mypy in ci #2671
Conversation
| @@ -31,7 +32,12 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| pip install -U pip "setuptools<79.0.0" wheel | |||
| SETUPTOOLS_ENABLE_FEATURES=legacy-editable pip install -r ./requirements.txt | |||
| SETUPTOOLS_ENABLE_FEATURES=legacy-editable pip install -r ./requirements-base.txt | |||
There was a problem hiding this comment.
you can keep old requirements.txt and add pip install -U "mypy==${{ matrix.mypy-version }}"
There was a problem hiding this comment.
I wanted to avoid installing 2 versions of mypy to gain some ci time.
Anyways, this should be much easier to handle once we revive the project.toml PR, might do that later
There was a problem hiding this comment.
Sadly specifying multiple editable dependencies does not seem to be possible with a pyproject.toml file yet. From PEP 735:
Special attention was devoted to attempting to standardize the expression of editable installations, as expressed by pip install -e and PEP 660. However, although the creation of editable installs is standardized for build backends, the behavior of editables is not standardized for installers. Inclusion of editables in this PEP requires that any supporting tool allows for the installation of editables.
Therefore, although Poetry and PDM provide syntaxes for some of these features, they are considered insufficiently standardized at present for inclusion in Dependency Groups.
So I don't think we can completely remove the requirements.txt file without switching to something like uv.
I'll be happy to do that if you guys agree, it should also simplify the local setup to a simple uv sync command, making contributions easier.
wdyt @sobolevn @adamchainz ?
There was a problem hiding this comment.
sure, let's move to uv. current setup is broken for local development :(
I have made things!
Run ci with mypy
1.13,1.14,1.15andmasterbranch on github.I'm not sure it's worth doing the full matrix with the python version wdyt @sobolevn ?