Skip to content

Col.__init__ has wrong type for argument target #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jerch opened this issue Jan 25, 2022 · 2 comments
Closed

Col.__init__ has wrong type for argument target #830

jerch opened this issue Jan 25, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@jerch
Copy link

jerch commented Jan 25, 2022

Bug report

What's wrong

This is the current Col type declaration:

django-stubs/django-stubs/db/models/expressions.pyi

Lines 189 to 190 in 515e382

class Col(Expression):
def __init__(self, alias: str, target: str, output_field: Optional[_OutputField] = ...): ...

Looking at django sources, target is meant to be a Field type, not str.

How is that should be

Make target a Field type.
@jerch jerch added the bug Something isn't working label Jan 25, 2022
@jerch jerch changed the title Col.__init__ has wrong argument type for target Col.__init__ has wrong type for argument target Jan 25, 2022
@sobolevn
Copy link
Member

PR is welcome!

himanshu-balasamanta added a commit to himanshu-balasamanta/django-stubs that referenced this issue Mar 10, 2022
@himanshu-balasamanta
Fixes typeddjango#830
44965c4 
Signed-off-by: Himanshu-Balasamanta <[email protected]>
Closed
himanshu-balasamanta added a commit to himanshu-balasamanta/django-stubs that referenced this issue Mar 10, 2022
@himanshu-balasamanta
Fixes typeddjango#830
9b8bed6 
Signed-off-by: Himanshu-Balasamanta <[email protected]>
@sobolevn
Copy link
Member

Fixed in #909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue#830 himanshu-balasamanta/django-stubs
2 participants
@sobolevn @jerch