Fail the build when noEmitOnError is set and there's a type error
#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dfreeman
commented
Apr 15, 2018
dfreeman
commented
Member
Author
|
@chriskrycho I didn't add anything to the README on this because I figured you may have thoughts on the best way to frame this as it relates to the overall effort of getting an app typechecking. Feel free to layer on any doc updates you've got to this branch, or give me a shout at some point and I can write something up. |
Member
|
SWEET. I'll write this up today. This is exactly what I was hoping we could do. |
Member
|
Pulled in a couple changes, will add more this afternoon. After that, I expect to merge and then cut a 1.3.0-beta.1 release. |
Member
|
…I think we somehow broke AppVeyor last night, @dfreeman. 😭 |
Member
|
Oh! Ha. No: it just didn't trigger a new build because there's no change that it should build, but GitHub isn't realizing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.