Skip to content

fix: getAll Factors #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Version 3.0.1
merged 6 commits into from
Oct 20, 2025
Merged

fix: getAll Factors #239

merged 6 commits into from
Oct 20, 2025

Conversation

@AlejandroOrozco
Copy link
Contributor

@AlejandroOrozco AlejandroOrozco commented Oct 2, 2025 •
edited by yafuquen
Loading

Ticket

  • [#####]

Github Issue

  • ISSUE-

Description

Commit message

  • fix: Filter factors information to prevent getting biometrics protected data

Screenshot

Testing

  • Added unit tests
  • Ran unit tests successfully
  • Added documentation for public APIs and/or Wiki

@AlejandroOrozco AlejandroOrozco self-assigned this Oct 2, 2025
@AlejandroOrozco AlejandroOrozco force-pushed the fix/GetAllKeychainItems branch 7 times, most recently from 947832e to 8498721 Compare October 6, 2025 19:30
@AlejandroOrozco
fix: filter Keychain items to include only those with AfterFirstUnloc…
d5fd5b9 
…k or AfterFirstUnlockThisDeviceOnly accessibility.
@AlejandroOrozco AlejandroOrozco force-pushed the fix/GetAllKeychainItems branch from 8498721 to d5fd5b9 Compare October 6, 2025 19:43
@AlejandroOrozco AlejandroOrozco marked this pull request as ready for review October 6, 2025 19:46
@AlejandroOrozco AlejandroOrozco force-pushed the fix/GetAllKeychainItems branch 5 times, most recently from 1f621a1 to 291a3ff Compare October 9, 2025 23:12
@AlejandroOrozco AlejandroOrozco force-pushed the fix/GetAllKeychainItems branch from 291a3ff to d123a43 Compare October 9, 2025 23:20
@authid-sdk-ci
Copy link
Contributor

6 Warnings
⚠️ TwilioVerifySDK/TwilioSecurity/Sources/Keychain/KeychainQuery.swift#L57 - This memberwise initializer would be synthesized automatically - you do not need to define it
unneeded_synthesized_initializer KeychainQuery.swift:57
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Keychain/KeychainQueryTests.swift#L23 - Use 'next', 'this' or 'previous' instead to disable the 'force_cast' rule once, or re-enable it as soon as possible blanket_disable_command KeychainQueryTests.swift:23`
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Keychain/KeychainQueryTests.swift#L78 - Prefer non-optional Data(_:) initializer when converting String to Data
non_optional_string_data_conversion KeychainQueryTests.swift:78
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Keychain/KeychainQueryTests.swift#L147 - Prefer non-optional Data(_:) initializer when converting String to Data
non_optional_string_data_conversion KeychainQueryTests.swift:147
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Keychain/KeychainQueryTests.swift#L164 - Prefer non-optional Data(_:) initializer when converting String to Data
non_optional_string_data_conversion KeychainQueryTests.swift:164
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Storage/SecureStorageTests.swift#L23 - Use 'next', 'this' or 'previous' instead to disable the 'force_cast' rule once, or re-enable it as soon as possible blanket_disable_command SecureStorageTests.swift:23`

Code coverage

Total coverage: 94.18%

File Coverage
TwilioVerifySDK/TwilioSecurity/Sources/Keychain/Keychain.swift 87.44%
TwilioVerifySDK/TwilioSecurity/Sources/Keychain/KeychainQuery.swift 100.00%
TwilioVerifySDK/TwilioSecurity/Sources/Storage/SecureStorage.swift 88.76%

Powered by Slather

Generated by 🚫 Danger

@authid-sdk-ci
Copy link
Contributor

6 Warnings
⚠️ TwilioVerifySDK/TwilioSecurity/Sources/Keychain/KeychainQuery.swift#L57 - This memberwise initializer would be synthesized automatically - you do not need to define it
unneeded_synthesized_initializer KeychainQuery.swift:57
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Keychain/KeychainQueryTests.swift#L23 - Use 'next', 'this' or 'previous' instead to disable the 'force_cast' rule once, or re-enable it as soon as possible blanket_disable_command KeychainQueryTests.swift:23`
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Keychain/KeychainQueryTests.swift#L78 - Prefer non-optional Data(_:) initializer when converting String to Data
non_optional_string_data_conversion KeychainQueryTests.swift:78
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Keychain/KeychainQueryTests.swift#L147 - Prefer non-optional Data(_:) initializer when converting String to Data
non_optional_string_data_conversion KeychainQueryTests.swift:147
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Keychain/KeychainQueryTests.swift#L164 - Prefer non-optional Data(_:) initializer when converting String to Data
non_optional_string_data_conversion KeychainQueryTests.swift:164
⚠️ TwilioVerifySDKTests/TwilioSecurity/Sources/Storage/SecureStorageTests.swift#L23 - Use 'next', 'this' or 'previous' instead to disable the 'force_cast' rule once, or re-enable it as soon as possible blanket_disable_command SecureStorageTests.swift:23`

Code coverage

Total coverage: 83.33%

File Coverage
TwilioVerifySDK/TwilioSecurity/Sources/Keychain/Keychain.swift 86.05%
TwilioVerifySDK/TwilioSecurity/Sources/Keychain/KeychainQuery.swift 98.08%
TwilioVerifySDK/TwilioSecurity/Sources/Storage/SecureStorage.swift 88.76%

Powered by Slather

Generated by 🚫 Danger

yafuquen
yafuquen reviewed Oct 14, 2025
View reviewed changes
.circleci/config.yml
test_plan: IntegrationSuite
ftl_devices: all
- cleanup-signing
device: "iPad Pro 11-inch (M4)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use iOS 18 for this case?

@AlejandroOrozco AlejandroOrozco merged commit 1d35541 into dev Oct 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yafuquen yafuquen yafuquen approved these changes

@catalinaalcala catalinaalcala Awaiting requested review from catalinaalcala catalinaalcala is a code owner

Assignees

@AlejandroOrozco AlejandroOrozco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlejandroOrozco @authid-sdk-ci @yafuquen