Skip to content

fix: added new httpclient for noauth and bearertoken requests #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Jul 25, 2024

Fixes

With OAuth support HttpClient class method argument type got changed due to which it was breaking customer environment.

Before: twilio-java/src/main/java/com/twilio/http/HttpClient.java at de885af34a8a9e71c62b488b7119bccde5abc4de · twilio/twilio-java

After: twilio-java/src/main/java/com/twilio/http/HttpClient.java at ab74cef9752400749fe23b9d7345d8bea27864c9 · twilio/twilio-java

Revert the interface changes.

Create separate clients for BearerToken and NoAuth Requests

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sbansla sbansla marked this pull request as ready for review July 31, 2024 03:49
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
55.0% Coverage on New Code (required ≥ 80%)
49.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sbansla sbansla requested a review from AsabuHere July 31, 2024 06:10
Copy link
Contributor

@AsabuHere AsabuHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbansla sbansla merged commit d47fbe1 into main Aug 13, 2024
11 of 12 checks passed
@sbansla sbansla deleted the fix-bug-http-client branch August 13, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants