Catch NPE when creating URI #471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR catches an NPE that is thrown when passing in a
null
url toMessageCreator.setMediaUrl()
.A few reasons it makes sense to do this:
MessageCreator.create()
itself handlesnull
values for any params:twilio-java/src/main/java/com/twilio/rest/api/v2010/account/MessageCreator.java
Line 501 in ce1c451
null
mediaUrl string messes up the flow using the API:turns into this:
URISyntaxException
.twilio-java/src/main/java/com/twilio/converter/Promoter.java
Line 21 in ce1c451
Contributing to Twilio