Skip to content

feature: #90 allow users to specify a github token #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2020
Merged

feature: #90 allow users to specify a github token #96

merged 3 commits into from
Jan 27, 2020

Conversation

badsketch
Copy link
Contributor

Adds #90 functionality by allowing the user to circumvent rate limiting with an auth token specified in their environment.

First time contributing to a CLI, so looking for suggestions on improvement. 🙂

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@badsketch
feat(templates): improve error message when github rate limited
14c2363
@badsketch
feat(templates): add option to specify github auth token
4e3ce46 
users pulling templates from github can bypass rate limit by specifying a
TWILIO_SERVERLESS_GITHUB_TOKEN in their environment

fix twilio-labs#90
badsketch
badsketch commented Nov 16, 2019
View reviewed changes
badsketch
badsketch commented Nov 16, 2019
View reviewed changes
dkundel
dkundel suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@dkundel dkundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @badsketch thanks for the PR and sorry for the super long delay on this. The last two months have been quite the roller-coaster for me :) but I'll try to be on top of things again. I left a few comments. If you could address those I'm happy to merge this :)

@badsketch
Copy link
Contributor Author

@dkundel No worries I understand! Thanks for taking the time to offer thoughtful comments. I'll address these issues. Cheers 🎉

@badsketch badsketch requested a review from dkundel January 20, 2020 08:38
@dkundel dkundel changed the title feature: #90 allow users to specify a github token feature: #90 allow users to specify a github token Jan 27, 2020
@dkundel dkundel merged commit f4b3038 into twilio-labs:master Jan 27, 2020
@welcome
Copy link

welcome bot commented Jan 27, 2020

Congratulations on your first contribution to the Serverless Toolkit!
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
If you want to stay up-to-date with Twilio's OSS activities, subscribe here: https://twil.io/oss-updates
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

@pika-ci
Copy link

pika-ci bot commented Jan 27, 2020

🚀 This PR has been merged! Once a new release is created, any changes will become available on npm. Until then, you can load and install it directly from the Pika CDN:

npm install https://cdn.pika.dev/twilio-run/master

@snyk-bot snyk-bot mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dkundel dkundel dkundel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badsketch @dkundel