feat: add estimated execution time to function run #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use process.hrtime.bigint() to track start/stop - debug log estimated execution time in milliseconds Not sure if requiring debug() is the correct way to report this information. We could also consider displaying a warning/error message if the estimated duration execeeds the defined limit. Another approach to capturing timing would be to use perf_hooks to setup an observer and add measurements. The observer could process the measurements (logging) and disconnect.
|
|
- fix trying to use process.hrtime.bigint() on nodeJS 6.x
dkundel
suggested changes
Sep 25, 2019
- moving debug statement before error handling/return
dkundel
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if requiring debug() is the correct way to report this information. We could also consider displaying a warning/error message if the estimated duration execeeds the defined limit.
Another approach to capturing timing would be to use perf_hooks to setup an observer and add measurements. The observer could process the measurements (logging) and disconnect.
Contributing to Twilio