Skip to content

Conversation

philnash
Copy link
Contributor

create-twilio-function uses downloadTemplate from src/templating/actions and that would previously throw an error for a missing/nonexistant template, but it changed to catch it. Downstream functions shouldn't catch and log errors because the function consumers won't know if something went wrong.

Fixes create-twilio-function#51.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

create-twilio-function uses downloadTemplate from src/templating/actions and that would previously throw an error for a missing/nonexistant template, but it changed to catch it. Downstream functions shouldn't catch and log errors because the function consumers won't know if something went wrong.
@philnash philnash changed the title fix(templating): catch errors in command, not before. fix(templating): catch errors in command, not before Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing
2 participants