Skip to content

fix(checks): change the expected node version #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2020
Merged

fix(checks): change the expected node version #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.10
10.17
3 changes: 1 addition & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ language: node_js

node_js:
- 'stable'
- '8'
- '9'
- '10'
- '12'

sudo: false

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ This project contains the CLI aspects of deploying Twilio Serverless as well as

## Requirements

Make sure you have Node.js 8.10 or newer installed. Due to compatibility with Twilio
Functions this project has to support at least Node.js 8.10.
Make sure you have Node.js 10.17 or newer installed. Due to compatibility with Twilio
Functions this project has to support at least Node.js 10.17.

## Setup

Expand Down
2 changes: 1 addition & 1 deletion src/checks/nodejs-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { stripIndent } from 'common-tags';
import { logger } from '../utils/logger';

const SERVERLESS_NODE_JS_VERSION = '8.10';
const SERVERLESS_NODE_JS_VERSION = '10.17';

export function printVersionWarning(
nodeVersion: string,
Expand Down