Last email interaction extension #15511

BOHEUS · 2025-11-01T16:35:42Z

Challenge 4 from "Call for projects" list

greptile-apps

Greptile Overview

Greptile Summary

This PR implements a Twenty extension that automatically tracks email interactions by updating lastInteraction and interactionStatus fields on Person and Company records when messages are created or updated.

Key Changes:

Added new extension package with Yarn 4.9.2 configuration
Implemented serverless function that triggers on message.created and message.updated events
Automatically creates custom fields (lastInteraction and interactionStatus) if they don't exist
Calculates interaction status based on time since last email (Recent: <7 days, Active: <30 days, Cooling: <90 days, Dormant: >=90 days)
Updates all related people and companies from message participants

Critical Issues Found:

Hardcoded API key exposed in package.json (security risk)
Syntax error: trailing comma in options array
Incorrect data structure: interactionStatus sent as array instead of string
Field configuration mismatch: isNullable: false with defaultValue: null
Multiple sequential API calls without proper rate limiting protection

Confidence Score: 0/5

This PR cannot be merged safely due to multiple critical issues including exposed credentials, syntax errors, and logic bugs
Score reflects critical security issue (hardcoded API key), syntax error that will prevent execution, and multiple logic bugs that will cause runtime failures
Pay critical attention to package.json (exposed API key) and serverlessFunctions/test/src/index.ts (multiple syntax and logic errors)

Important Files Changed

File Analysis

Filename	Score	Overview
packages/twenty-apps/last_email_interaction/package.json	1/5	Contains hardcoded API key that must be removed before merging
packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts	1/5	Multiple critical issues: syntax error (trailing comma), incorrect data structure (array instead of string), isNullable/defaultValue mismatch, and rate limiting concerns

Sequence Diagram

sequenceDiagram
    participant Message as Message Event
    participant Function as Serverless Function
    participant API as Twenty REST API
    participant DB as Database

    Message->>Function: message.created/updated
    Function->>API: GET /metadata/objects
    API-->>Function: Return objects metadata
    
    alt Fields don't exist
        Function->>API: POST /metadata/fields (lastInteraction)
        API-->>DB: Create field
        Function->>API: POST /metadata/fields (interactionStatus)
        API-->>DB: Create field
    end
    
    Function->>API: GET /messages/{recordId}?depth=1
    API-->>Function: Return message with participants
    
    loop For each participant
        Function->>API: GET /people/{id}
        API-->>Function: Return person with companyId
    end
    
    loop For each person
        Function->>API: PATCH /people/{id}
        API-->>DB: Update lastInteraction & interactionStatus
    end
    
    loop For each company
        Function->>API: PATCH /companies/{id}
        API-->>DB: Update lastInteraction & interactionStatus
    end

_{6 files reviewed, 8 comments}

_{Edit Code Review Agent Settings | Greptile}

packages/twenty-apps/last_email_interaction/package.json

packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts

greptile-apps · 2025-11-01T16:38:58Z

packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts

+    for (const id of peopleIds) {
+      const options = {
+        method: 'GET',
+        url: `${TWENTY_URL}/people/${id}`,
+        headers: {
+          Authorization: `Bearer ${TWENTY_API_KEY}`
+        }
+      };
+      const req = await axios.request(options);
+      companiesIds.push(req.data.person.companyId);
+    }


logic: Multiple sequential API calls without delay between them will cause rate limiting issues. Add delays or use Promise.all with batch processing

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts Line: 173:183 Comment: **logic:** Multiple sequential API calls without delay between them will cause rate limiting issues. Add delays or use Promise.all with batch processing How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2025-11-01T16:38:59Z

packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts

+    for (const id of peopleIds) {
+      const peopleOptions = {
+        method: 'PATCH',
+        url: `${TWENTY_URL}/people/${id}`,
+        headers: {
+          'Content-Type': "application/json",
+          Authorization: `Bearer ${TWENTY_API_KEY}`
+        },
+        data: interactionData(messageDate, interactionStatus)
+      }
+      const req = await axios.request(peopleOptions);
+      if (req.status === 200) {
+        console.log(`Successfully updated person with ID ${id}`);
+        await setTimeout(DELAY);
+      }
+    }


style: Sequential updates without proper error handling. If one update fails, subsequent updates won't execute

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts Line: 185:200 Comment: **style:** Sequential updates without proper error handling. If one update fails, subsequent updates won't execute How can I resolve this? If you propose a fix, please make it concise.

packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts

sentry · 2025-11-03T09:59:54Z

packages/twenty-apps/last_email_interaction/package.json

+    },
+    "TWENTY_API_URL": {
+      "isSecret": false,
+      "value": "",
+      "description": "Optional, defaults to cloud API URL"
+    }
+  },
+  "dependencies": {
+    "axios": "^1.12.2"
+  }
+}


Bug: twenty app sync fails due to missing application.config.ts and twenty-sdk dependency in package.json.
_{Severity: CRITICAL | Confidence: 0.99}

🔍 Detailed Analysis

The twenty app sync command will fail because the extractTwentyAppConfig function, called by loadManifest, unconditionally throws an error if application.config.ts is not found. This file is missing from the last_email_interaction app, preventing successful setup. Users following the documented setup instructions will immediately encounter this error. Additionally, the package.json is missing the twenty-sdk dependency, which is required for type imports.

💡 Suggested Fix

Create application.config.ts with a default ApplicationConfig export. Add "twenty-sdk" to the dependencies in package.json.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/twenty-apps/last_email_interaction/package.json#L1-L29 Potential issue: The `twenty app sync` command will fail because the `extractTwentyAppConfig` function, called by `loadManifest`, unconditionally throws an error if `application.config.ts` is not found. This file is missing from the `last_email_interaction` app, preventing successful setup. Users following the documented setup instructions will immediately encounter this error. Additionally, the `package.json` is missing the `twenty-sdk` dependency, which is required for type imports.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

greptile-apps

Greptile Overview

Greptile Summary

Implements a serverless function that tracks last email interactions by creating custom fields (lastInteraction and interactionStatus) on person and company objects, then updates them based on email receivedAt timestamps.

Key Changes:

Added README with setup instructions
Created package.json manifest with environment configuration
Implemented main serverless function that:
- Checks/creates required custom fields dynamically
- Calculates interaction status (RECENT/ACTIVE/COOLING/DORMANT) based on time since last email
- Fetches message participants and their associated companies
- Updates person and company records with interaction data

Critical Issues Found:

Line 231: Wrong variable options used instead of peopleOptions - will cause runtime error
Line 210: Null companyId values not filtered, causing failed PATCH requests
Multiple syntax errors from previous review still present (trailing comma, array instead of string)

Confidence Score: 0/5

This PR cannot be merged - it contains critical bugs that will cause runtime failures
Multiple critical logic errors exist: using undefined variable (line 231), missing null checks for companyId (line 210), and unresolved syntax errors from previous review. These will cause immediate runtime failures when the function executes.
packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts requires immediate attention - contains multiple critical bugs that prevent execution

Important Files Changed

File Analysis

Filename	Score	Overview
packages/twenty-apps/last_email_interaction/README.md	5/5	Documentation file describing setup and flow. Clear and well-structured with no issues.
packages/twenty-apps/last_email_interaction/package.json	4/5	Configuration manifest. API key issue resolved (now empty string). Minor version/dependency definitions.
packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts	1/5	Main implementation with critical bugs: wrong variable used (line 231), null companyId handling missing, syntax/logic errors from previous comments unresolved.

Sequence Diagram

sequenceDiagram
    participant Trigger as Webhook Trigger
    participant Main as main()
    participant API as Twenty REST API
    participant Meta as Metadata API
    participant Messages as Messages API
    participant People as People API
    participant Companies as Companies API

    Trigger->>Main: New email received (recordId, properties)
    Main->>API: GET /metadata/objects
    API-->>Main: Return all objects (company, person)
    
    alt Company fields missing
        Main->>Meta: POST /metadata/fields (lastInteraction)
        Meta-->>Main: Field created
        Main->>Meta: POST /metadata/fields (interactionStatus)
        Meta-->>Main: Field created
    end
    
    alt Person fields missing
        Main->>Meta: POST /metadata/fields (lastInteraction)
        Meta-->>Main: Field created
        Main->>Meta: POST /metadata/fields (interactionStatus)
        Meta-->>Main: Field created
    end
    
    Main->>Main: Calculate interaction status from receivedAt
    Main->>Messages: GET /messages/{recordId}?depth=1
    Messages-->>Main: Message with participants
    
    loop For each participant
        Main->>People: GET /people/{personId}
        People-->>Main: Person with companyId
        Main->>Main: Collect companyId (may be null)
    end
    
    loop For each person
        Main->>People: PATCH /people/{personId} (BUG: uses wrong variable)
        People-->>Main: Updated
    end
    
    loop For each company (including nulls)
        Main->>Companies: PATCH /companies/{companyId}
        Companies-->>Main: Updated or Error
    end
    
    Main-->>Trigger: Return {}

_{3 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2025-11-03T10:02:09Z

packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts

+        data: interactionData(messageDate, interactionStatus),
+      };
+      try {
+        const response = await axios.request(options);


logic: Wrong variable used. Should be peopleOptions not options

Suggested change

const response = await axios.request(options);

const response = await axios.request(peopleOptions);

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts Line: 231:231 Comment: **logic:** Wrong variable used. Should be `peopleOptions` not `options` ```suggestion const response = await axios.request(peopleOptions); ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2025-11-03T10:02:09Z

packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts

+      };
+      try {
+        const req = await axios.request(options);
+        companiesIds.push(req.data.person.companyId);


logic: companyId can be null/undefined if person not linked to company. Will cause issues when updating companies

Suggested change

companiesIds.push(req.data.person.companyId);

if (req.data.person.companyId) {

companiesIds.push(req.data.person.companyId);

}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts Line: 210:210 Comment: **logic:** `companyId` can be null/undefined if person not linked to company. Will cause issues when updating companies ```suggestion if (req.data.person.companyId) { companiesIds.push(req.data.person.companyId); } ``` How can I resolve this? If you propose a fix, please make it concise.

martmull

Hey, thank you for your submission!
Code looks nice, did not test it yet
Some comments if you want to take a look
Cheers

martmull · 2025-11-03T10:51:34Z

packages/twenty-apps/last_email_interaction/package.json

+    },
+    "TWENTY_API_URL": {
+      "isSecret": false,
+      "value": "",


Please, add default value to "value"

By default you mean "default":"{value}" or "value":"{value}"? Also, is it necessary when in first lines of code I'm checking if TWENTY_API_URL is defined and if not, it defaults to cloud API URL

martmull · 2025-11-03T10:59:24Z

packages/twenty-apps/last_email_interaction/serverlessFunctions/test/src/index.ts

+      if (response2.status === 201) {
+        console.log('Successfully created person interaction status field');
+      }
+      await setTimeout(DELAY);


Why do you need await setTimeout(DELAY); everywhere?

Original idea was to just add a little bit of delay between requests to prevent accidentally DDoSing workspace but I think something else should be done if it's necessary

BOHEUS · 2025-11-03T15:45:18Z

@martmull thanks for review, left questions to comments as I'm not entirely sure about them

WIP Last email interaction extension

999e010

greptile-apps bot reviewed Nov 1, 2025

View reviewed changes

BOHEUS marked this pull request as draft November 1, 2025 16:53

charlesBochet added the HACKTOBERFEST_2025 Temporary label for hacktoberfest 2025 submissions label Nov 1, 2025

Fix README and change logic

38fe304

BOHEUS marked this pull request as ready for review November 3, 2025 09:58

sentry bot reviewed Nov 3, 2025

View reviewed changes

greptile-apps bot reviewed Nov 3, 2025

View reviewed changes

martmull self-requested a review November 3, 2025 10:44

martmull self-assigned this Nov 3, 2025

martmull reviewed Nov 3, 2025

View reviewed changes

martmull added the -PR: awaiting author label Nov 3, 2025

martmull approved these changes Nov 4, 2025

View reviewed changes

martmull merged commit e4dbe87 into twentyhq:main Nov 4, 2025
43 checks passed

BOHEUS deleted the last_email_interaction branch November 13, 2025 07:57

	const response = await axios.request(options);
	const response = await axios.request(peopleOptions);

Last email interaction extension #15511

Last email interaction extension #15511

Uh oh!

Conversation

BOHEUS commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Overview

Greptile Summary

Confidence Score: 0/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sentry bot Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Overview

Greptile Summary

Confidence Score: 0/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

martmull left a comment

Choose a reason for hiding this comment

Uh oh!

martmull Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

BOHEUS Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

martmull Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

BOHEUS Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

BOHEUS commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BOHEUS commented Nov 1, 2025 •

edited

Loading