Move away from -latest runner images #2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using ubuntu-latest might break any time GitHub switches the runner image to a different base.
avdv
force-pushed
the
cb/fix-ci-ubuntu-24.04
branch
2 times, most recently
from
35cd5e8 to
55f4ceb
Compare
This package is no longer available on ubuntu-24.04.
Instead of choosing the oldest debian distribution tarball, which does not work anymore on newer Ubuntu systems as these lack the required libtinfo5 library, we want to be able to choose arbitrary dist and variant.
avdv
force-pushed
the
cb/fix-ci-ubuntu-24.04
branch
2 times, most recently
from
816d5e5 to
f174c53
Compare
This change should be backwards compatible, since the attrs are not mandatory and on Linux we choose the oldest Debian tarball if no dist / variant has been specified explicitly.
Testing all releases is getting too cumbersome to deal with, and ensuring the latest release works should be good enough.
avdv
force-pushed
the
cb/fix-ci-ubuntu-24.04
branch
from
f174c53 to
e49088d
Compare
On newer Ubuntu systems, older ghc binary distributions do not work anymore since they are lacking the legacy tinfo5 library package. Note, there are also Ubuntu specific binary distributions available, such as `ubuntu18_04`, `ubuntu20_04` and even `ubuntu22_04`, but these are not available for all GHC versions and the Debian based ones are working just as well.
Remove the bindist toolchains, since these are not needed.
Some older GHC binary distributions (notably 9.0.2) depend on it. See https://gitlab.haskell.org/ghc/ghc/-/issues/15688
- recent systems need `libtinfo6` instead of `libtinfo5` - python2 is no longer used and the `python` package is no longer available
avdv
force-pushed
the
cb/fix-ci-ubuntu-24.04
branch
from
e49088d to
5a8d572
Compare
ylecornec
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever these runner images are changed to a new base, workflows might start to fail.
Rather, we want to switch to a new image consciously.