- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 79.2k
 
Docs: Add missing type="button" to Cheatsheet nav buttons #39585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            julien-deramond
  merged 2 commits into
  twbs:main
from
coliff:dev/coliff/cheatsheet-button-fix
  
      
      
   
  Jan 30, 2024 
      
    
                
     Merged
            
            Docs: Add missing type="button" to Cheatsheet nav buttons #39585
                    julien-deramond
  merged 2 commits into
  twbs:main
from
coliff:dev/coliff/cheatsheet-button-fix
  
      
      
   
  Jan 30, 2024 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    louismaximepiton
  
              
              approved these changes
              
                  
                    Jan 22, 2024 
                  
              
              
            
            
              
                    patrickhlauke
  
              
              approved these changes
              
                  
                    Jan 22, 2024 
                  
              
              
            
            
              
                    julien-deramond
  
              
              approved these changes
              
                  
                    Jan 30, 2024 
                  
              
              
            
            
  This was referenced May 19, 2024 
      
  This was referenced May 24, 2024 
      
  This was referenced Oct 2, 2024 
      
  This was referenced Oct 5, 2024 
      
  This was referenced Oct 12, 2024 
      
  This was referenced Oct 15, 2024 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Fix a very minor issue (reported by Webhint):
https://webhint.io/docs/user-guide/hints/hint-button-type/
Motivation & Context
The default type for is submit (not type="button" as one might expect). This can lead to surprising keyboard behavior within a form. We added
type="button"to all other buttons on the site - makes sense to add them here too.Type of changes
Checklist
npm run lint)Live previews
Related issues