Moved methods should be shown on split classes

[koppor]

Context: JabRef/jabref#12990

Even if I like the split view, there should be the possibility to see moved code

The class was split in two - with the same name.

• jabgui/src/test/java/org/jabref/gui/desktop/os/BibDatbaseContextTest.java
• jablib/src/test/java/org/jabref/model/database/BibDatabaseContextTest.java

Only the first one seems to be treated by RefactoringMiner.

typeBasedOnDefaultBibtex was moved to jablib/src/test/java/org/jabref/model/database/BibDatabaseContextTest.java

[tsantalis]

@koppor
For some reason only jabgui/src/test/java/org/jabref/gui/desktop/os/BibDatbaseContextTest.java is fetched from the PR.

I could not find jablib/src/test/java/org/jabref/model/database/BibDatabaseContextTest.java in your PR, when I checked on GitHub.
Maybe this is due to the 3,000 file limit.

If the file was fetched, the tool would be able to find the Split Class.

[tsantalis]

@koppor

OK, now I get it. This is the reason we generate two diffs for this file. The diffs capture correctly the change.

[koppor]

OK, now I get it. This is the reason we generate two diffs for this file. The diffs capture correctly the change.

Maybe, each diff view should offer navigation to other related diffs?

(I somehow remember the discussion that it was said that there can be n files involved in a refactoring; and therefore pairs of files are difficult to render)

[tsantalis]

@koppor
This is from your PR JabRef/jabref#13012

As you can see ArgumentProcessor has its own diff
and then there is a separate diff with => for each class where some code from ArgumentProcessor has been moved to.

In the previous case, the code was moved to a different package, and this is why the diffs were not after each other, but in this case the moves are in classes within the same package, and this is why they are shown together.

[tsantalis]

@koppor
Again from the same PR JabRef/jabref#13012

Some code from Launcher and JabKit was moved to IndexManager.
The code is actually duplicated.

When you open the IndexManager diff, you see a tooltip saying that the code was moved from two files.

[koppor]

As you can see ArgumentProcessor has its own diff and then there is a separate diff with => for each class where some code from ArgumentProcessor has been moved to.

OMG, I never really got these icons... 🙈

Maybe, I expected in the details view on the left ArgumentPRocessor and on the right all 5 source files where something moved to. -- Reason: I want to understand "as a whole" where something from ArgumentProcessor went to.

Mayb,e I would have not expected lines betwen the files - and just a gray shaded box grouping (!) the files. Meaning: The next change is either separated with a line, wich a white space - or has some other gray shade... (I am personally used to alternativing colors, but people tend to not like it -- nevertheless, it is employed in JabRef: https://github.com/JabRef/jabref#jabref-bibliography-management- - and to the extreme in the current alpha version)

[tsantalis]

@koppor
The diffs with => symbol show only the code that has been moved between the two files and try to hide the rest of the file contents.