Fix typing of kerberos mutual_authentication #542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #513 by correcting
mutual_authenticationtype annotation and adding corresponding mutual authentication modes constants.KerberosAuthenticationandGSSAPIAuthenticationclasses.mutual_authenticationattributes.requests_kerberos/requests_gssapi.Non-technical explanation
Kerberos/GSSAPI libraries (
requests_kerberosandrequests_gssapi) expectmutual_authenticationparameter to be an integer:1for "required"2for "optional"3for "disabled"However, the same parameter in
trino-python-clientis annotated asbool. By luck, due to the order of conditions and the fact thatTrue == 1, Kerberos/GSSAPI libraries handleTrue/Falseas "required"/"disabled" modes.This is non-breaking change, but it can streamline the usage of
KerberosAuthenticationa bit:Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: